-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add emoji reactions to task messages #5291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: matt <[email protected]>
|
Lol thanks cursor |
|
✅ No security or compliance issues detected. Reviewed everything up to cbdecd1. Security Overview
Detected Code Changes
Reply to this PR with |
| size="sm" | ||
| className="h-6 w-6 p-0 text-xs hover:bg-vscode-button-secondaryHoverBackground" | ||
| onClick={() => setShowPicker(!showPicker)} | ||
| title="Add reaction" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider localizing the 'Add reaction' button title instead of hardcoding it. Use a translation function (e.g., t('emojiReactions.add')) to support multiple languages.
| title="Add reaction" | |
| title={t('emojiReactions.add')} |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| setShowPicker(false) | ||
| } | ||
|
|
||
| const hasReactions = Object.keys(reactions).some(emoji => reactions[emoji] > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The computed variable 'hasReactions' is declared but not used. Remove it to simplify the code.
| const hasReactions = Object.keys(reactions).some(emoji => reactions[emoji] > 0) |
|
Wrong repo 😆 |
Important
Add emoji reactions to task messages with real-time updates and persistence across sessions.
EmojiReactions.tsxcomponent.ClineMessageinmessage.tsto includereactionsfield.addReactionandremoveReactionmethods inTask.tsfor managing reactions.webviewMessageHandler.tsto handleaddReactionandremoveReactionmessages.EmojiReactionsinChatRow.tsxfor eligible message types.This description was created by
for cbdecd1. You can customize this summary. It will automatically update as commits are pushed.